search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 26 forks source link

Fix usage of incorrect data type in curl_easy_getinfo #112

Closed ajum closed 1 year ago

ajum commented 1 year ago

The bug that this fixes causes libvault to crash when linked against certain versions of curl

ajum commented 1 year ago

This addresses https://github.com/abedra/libvault/issues/111

ajum commented 1 year ago

By the way, the failed check is due to CodeQL's version being deprecated

Error: This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

abedra commented 1 year ago

Thanks for the submission. Any idea for what versions of curl this came up? I was a bit surprised.

ajum commented 1 year ago

I experienced crashing with curl version 7.29

abedra commented 1 year ago

I experienced crashing with curl version 7.29

Ok thanks. That's much farther back than I had gone in testing. I only went back into the 50s.