Windows: libvault dll name shouldn't be `vault.dll` since `Vault.dll` is already a system lib on Windows

abedra / libvault

A C++ library for Hashicorp Vault

MIT License

34 stars 25 forks source link

Windows: libvault dll name shouldn't be `vault.dll` since `Vault.dll` is already a system lib on Windows #116

Closed SpaceIm closed 1 year ago

SpaceIm commented 1 year ago

dll name is vault.dll but Vault.dll is a system lib on Windows, so there is a conflict here where runtime loader will find system Vault.dll first (windows is case insensitive) instead of vault.dll.

abedra commented 1 year ago

I think the PR referenced above should do the trick, but I don't have a Windows build environment to verify. Can you confirm?

abedra commented 1 year ago

Released in 0.57.0