abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 26 forks source link

clear build warning list #120

Closed s1Sharp closed 11 months ago

s1Sharp commented 1 year ago

remove warnings like:

s1Sharp commented 11 months ago

It looks like there are formatting changes along with the relevant updates. Can you please resubmit without the formatting changes to make the actual changes more apparent?

I've made a few changes.

s1Sharp commented 11 months ago

now member in class and in constructor member init sequence the same

  bool debug_;
  bool tls_;
  Host host_;
  Port port_;
  Token token_;
  Namespace namespace_;
  HttpClient httpClient_;
  AuthenticationStrategy &authStrategy_;
  std::filesystem::path caBundle_;
  : debug_(config.getDebug())
  , tls_(config.getTls())
  , host_(config.getHost())
  , port_(config.getPort())
  , namespace_(config.getNamespace())
  , httpClient_(HttpClient(config))
  , authStrategy_(authStrategy)
  , caBundle_(config.getCaBundle())
  // + `Token token` init in constructor body {...}
abedra commented 11 months ago

Thank you!