search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 25 forks source link

Add proper tiny types #51

Closed abedra closed 4 years ago

abedra commented 4 years ago

Closes #50

jimpark commented 4 years ago

Defining a macro in a public header file is not a good idea. Can you do it without a macro? Or if you insist on using macros, can you undef them after you are done with them so they don’t pollute client code?

abedra commented 4 years ago

Defining a macro in a public header file is not a good idea. Can you do it without a macro? Or if you insist on using macros, can you undef them after you are done with them so they don’t pollute client code?

Fair point, that's now sorted.

abedra commented 4 years ago

Interestingly enough, doing this found a place where I failed at my original mission. The change in SysTests.cpp shows that once I enforced the type it was an incorrect use of Vault::Path where it should have been Vault::Url.