search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 25 forks source link

Make PKI mount configurable #70

Closed othi closed 3 years ago

othi commented 3 years ago

Attemps to fix #69.

I copied the exact behaviour from the KeyValue engine.

abedra commented 3 years ago

Thanks for submitting this. I missed this when reading through the documentation. In addition to this PR, I would like to add some additional tests around it. I can either do that in a separate branch and just mention you in the resulting commit or you can take a crack at additional tests, completely up to you.

othi commented 3 years ago

If you don’t mind writing the tests ;) I’m not familiar with your testing suite. A mention is fine but not really necessary, in reality I just copied what you did for the KV engine and changed a few names.

abedra commented 3 years ago

I did some additional cleanup and wrote examples for the default and custom path cases. See #72 for more details