search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 26 forks source link

Replace CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMakeLists #76

Closed zspasztori closed 3 years ago

zspasztori commented 3 years ago

Hi,

I am building a library on top of vault lib. We are thinking about adding it through gitsbmodule or FetchContent. Unfortunately, it does not work right now because of this funny cmake behaviour related to CMAKE_SOURCE_DIR. https://stackoverflow.com/questions/22214349/modify-cmake-source-dir

Would you mind changing CMAKE_SOURCE_DIR to PROJECT_SOURCE_DIR?

I can create a pull request if you want, it is running locally.

abedra commented 3 years ago

All set, it's on master and the 0.38.0 release. What type of library are you building on top of libvault?

zspasztori commented 3 years ago

an opinionated client lib. Thank you for your quick reaction!

abedra commented 3 years ago

Will you open source the library?

zspasztori commented 3 years ago

it will be closed source