search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 26 forks source link

Zsp error callback httpconsumer #81

Closed zspasztori closed 3 years ago

zspasztori commented 3 years ago

Solves #79

zspasztori commented 3 years ago

updated pull request

zspasztori commented 3 years ago

the commit message got stuck from last time. Changed the signature of the callback.

zspasztori commented 3 years ago

did you manage to look at the new commit?

abedra commented 3 years ago

did you manage to look at the new commit?

I did. I resolved all but the one remaining comment. Once that's addressed this can be merged.