search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 25 forks source link

Add find package config #85

Closed zspasztori closed 3 years ago

zspasztori commented 3 years ago

This will allow users to use find_package(libvault) in their cmake files

Do you mind if I add libvault to conan hub? It is more for practice than anything. The package would look similar to this : https://github.com/zspasztori/vaultpkg

abedra commented 3 years ago

I'll take a look at this tonight. Regarding conanhub, I would like to maintain publishing control of the package. I had a conan package on bintray before they switched over. I would be more than happy to embed the conan packaging support into this repository and get it pushed out though. It's been on my recent todo list.

zspasztori commented 3 years ago

I dont quite understand what do you mean by "get it pushed out". Would it be available from conanhub to download? You can have a look at the repo I linked, I modified your recipe slightly. It works for me, just need to add the cmake find_package related 2 lines if you decided to merge this.

abedra commented 3 years ago

I dont quite understand what do you mean by "get it pushed out". Would it be available from conanhub to download? You can have a look at the repo I linked, I modified your recipe slightly. It works for me, just need to add the cmake find_package related 2 lines if you decided to merge this.

I'm not at all opposed to getting it into conanhub. My only concern here is owning the publishing credentials and controlling what gets uploaded to conanhub. I'd be happy to take another PR to add the conan build that you recently worked on and I can push it through my account.

zspasztori commented 3 years ago

I dont think there is such thing as publishing creditentials anymore. They deleted the user/channel stuff, it is now a single git repo and anyone can modify any recipe.

abedra commented 3 years ago

I dont think there is such thing as publishing creditentials anymore. They deleted the user/channel stuff, it is now a single git repo and anyone can modify any recipe.

Oh that's terrifying. I'll take another look. That seems like a tragic step backward.