Kanban board

[abel-tefera]

Kanban board

We are a team of 3 members

• Team member 1: @abel-tefera
• Team member 2: @newhoteng
• Team member 3: @Jeddaa

[mckent05]

Hi team,

STATUS: CHANGES REQUIRED ♻️ ♻️

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

• All tasks have been fairly assigned ✔️ ✔️
• Your tasks have good titles and descriptions 👍 👍

Required Changes ♻️

• Good job done so far, according to the project requirements, a project card should represent all Project requirements, some requirements are missing in your kanban Team member 1:
• Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:
  • • books table (add all properties and associations from the parent Item class as table columns)
  • • labels table Team member 2:
• Create MusicAlbum class in a separate .rb file
• Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:
  • • music_albums table (add all properties and associations from the parent Item class as table columns)
  • • genres table Team member 3:
• Create an Author class with an association to the Item class (in a separate .rb file).
• Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:
  • • games table (add all properties and associations from the parent Item class as table columns)
      • • author's table Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[newhoteng]

Kanban board

The requested changes have been made. Please note that the 'Create MusicAlbum class' task and the 'Create Genre class' task are on different cards.

• Team member 1: @abel-tefera
• Team member 2: @newhoteng
• Team member 3: @Jeddaa

[mckent05]

Hi team,

STATUS: APPROVED ✔️ ✔️

Your project is complete! There is nothing else to say other than... it's time start your capstone :shipit: Congratulations and well done! 🎉

Highlights

• All tasks have been fairly assigned ✔️ ✔️
• Your Kanban board is correctly set up 👏 👏

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.