search

abell95 / galaga_invaders

A retro remix of Galaga and Space Invaders
1 stars 0 forks source link

rename player.rb to player_ship.rb #9

Closed rasheedelkassed closed 5 years ago

rasheedelkassed commented 5 years ago

The name of the file is different from the class within.

bmchristensen commented 5 years ago

Specificity in class name is potentially restrictive. If this class was extended or inherited by another, the name would be misleading since the player does not control any other actors in the system. Specificity is important, but probably not at the cost of flexibility and tolerance to change. I propose that the player.rb aka player_ship.rb be renamed to ship.rb.