search

abelmartin / pull-requester

The source for http://www.pullrequester.com
GNU General Public License v2.0
1 stars 1 forks source link

Description field is badly formatted when there are code blocks or other formatting #37

Closed direction closed 11 years ago

direction commented 11 years ago

Raw

[Finished #56523024]

_Added a rspec matcher for has_serialized_hash but only added the tests for OfferDetail : feel free to add tests for the other call sites of has_serialized_hash_

Current

screen shot 2013-09-10 at 11 44 59 am

Should look more like:

screen shot 2013-09-10 at 11 45 49 am

abelmartin commented 11 years ago

The issue is you have content in a <code> tags smushed up next to text without any breaks.

The PR info column can't help you out in this case because <code> & <pre> blocks don't respect browser/css desired scrolling without wrapping them in other block-tags.

You can, however, scroll in the space. :smile:

abelmartin commented 11 years ago

Hmm...actually...it's all wrapped in an <em>. I'll see what i can do

direction commented 11 years ago

Yes it's wrapped in an em but I think it should respect what Github is doing in that info space too for consistency.

abelmartin commented 11 years ago

screen shot 2013-09-10 at 12 03 42 pm

As soon as I removed the extraneous "_" wrapping the PR content, everything renders correctly. I think this is going into the won't fix bucket I'm afraid, but please keep sending me anything you find. :smile:

direction commented 11 years ago

It's not extraneous. It's mean to be wrapped in an em tag. look at the github screenshot i attached to see how github does it

abelmartin commented 11 years ago

You're saying that your comment doesn't make sense unless it's italicized?

direction commented 11 years ago

No i'm saying I chose to italicize it.

Pullrequester should handle the case when a comment is italicized and has code blocks in it which it currently doesn't like Github clearly does.

abelmartin commented 11 years ago

Fine, @direction, fine.

Some people would just let things go...but noooooooo. @direction needs to have her precious italicized content. :stuck_out_tongue:

Reopening this horrible bug.

direction commented 11 years ago

hahahaha @abelmartin just admit that there's a bug and file it. you can choose to NEVER fix it :smiling_imp: