search

abeln / dotty

Scala with explicit nulls
https://github.com/abeln/dotty/wiki/scala-with-explicit-nulls
Other
23 stars 2 forks source link

Inline Nullify Policies in JavaNullInterop #29

Closed noti0na1 closed 5 years ago

abeln commented 5 years ago

@noti0na1 Is this ready for review? Thanks!

noti0na1 commented 5 years ago

@abeln Yes

noti0na1 commented 5 years ago

The compilation tests passed, but I'm not very confident with my change. I will double check my code tomorrow.

abeln commented 5 years ago

@noti0na1 I added a couple of comments. Thanks!

noti0na1 commented 5 years ago

@abeln If we nullify Seq[String] | String, the result is Seq[String] | String | JavaNull. Is this correct? I think the correct result should be Seq[String | JavaNull] | String | JavaNull. Also, I have a little concern about the call toJavaNullableUnion, If we have a large union, the time complexity would be O(n^2).

noti0na1 commented 5 years ago

@abeln Done