search

abelsiqueira / BestieTemplate.jl

Template for Julia Programming Language packages using the copier engine.
http://abelsiqueira.com/BestieTemplate.jl/
Mozilla Public License 2.0
38 stars 9 forks source link

[Bug] Lots of errors with fresh application in pre-commit #390

Closed moble closed 1 month ago

moble commented 1 month ago

Description

Running pre-commit run -a, as recommended in the docs, produced lots of errors from files that were added by BestieTemplate. For example, the various ISSUE_TEMPLATE files had lines that were too long. I had to tweak lots of config options, including adding a .yamllint.yaml file, to get past the errors.

Package Version

0.9.1

Julia Version

1.10.4

Reproduction steps

I applied Bestie to an existing package and ran pre-commit run -a.

Relevant log output

No response

Operating System

No response

abelsiqueira commented 1 month ago

Hum, pre-commit errors are expected for the first execution, but hopefully they should be fixed the pre-commit. The second execution of pre-commit run -a should work without manual intervention, unless the package itself has conflicting configuration or some file that can't be fixed.

Also, we have a .yamllint.yml file: https://github.com/abelsiqueira/BestieTemplate.jl/blob/main/template/%7B%25%20if%20AddPrecommit%20%25%7D.yamllint.yml%7B%25%20endif%20%25%7D.jinja

Can you share the package and the answers that you gave so we can try to reproduce? For a new repo it doesn't have any problems using the default answers.

abelsiqueira commented 1 month ago

I've implemented tests to make sure that the pre-commit errors are being fixed with the first execution of pre-commit. If this is not your experience, feel free to reopen this or open a new issue, but please help me reproduce it.