Put the compiler messages in the .out-file

abeltje / Test-Smoke

The Perl5 Core Smoke framework

6 stars 15 forks source link

Put the compiler messages in the .out-file #55

Closed abeltje closed 2 years ago

abeltje commented 2 years ago

https://github.com/abeltje/Test-Smoke/issues/54

Test::Smoke was relying on the logfile (created from STDOUT and STDERR redirecting) for its compilermessages. I now moved them to the .out-file

which should be more reliable - and adjusted the calls to grepccmsg and grepnonfatal.

bram-perl commented 2 years ago

This probably needs fixing for the MSVC (and/or borland) compiler; MSVC reports warning (not sure about errors) on stdout and not on stderr; Line 473 of Test::Smoke::Smoker:

    $self->{w32cc} =~ /MSVC|BORLAND|GCC/ and $self->tty( "\n$make_output\n" );

probably needs to be changed into:

    $self->{w32cc} =~ /MSVC|BORLAND|GCC/ and $self->log( "\n$make_output\n" );

I also suggest dropping GCC from that list.. GCC does report warnings/errors on stderr and these do end up in the proper place now

abeltje commented 2 years ago

applied