Fix modification of patchlevel.h

bram-perl commented 2 years ago

Test::Smoke 'modifies' patchlevel.h to include something like: 'SMOKE02cf5fb76fa9ca5db8d1b04f9087dd6d0f81848e' in the local_patches list.

The code to do that was silently broken: it was checking for a line that matched: /\t,NULL/ but that line no longer exist. perl5 tree was detabified in Jan 2021 so it now starts with 8 spaces and not with a tab.

This PR fixes that (by using /^(\s+),NULL/ instead of /\t,NULL/

Also in this PR:

die when changing local_patches failed (when the 'NULL'-marker couldn't be found)
update patchlevel.h that is used in testing (tests were using a copy of patchlevel.h of perl-5.9.2, update it to patchlevel.h of perl-5.37.4)

bram-perl commented 2 years ago

An alternative fix could also be to use patchlevel.h to do the patching. It contains an embedded perl script that can be run via: perl -x patchlevel.h "patch1 "patch2" "patch3"

(That code however is/was also broken in the same way.. PR https://github.com/Perl/perl5/pull/20198 was just created for it)

abeltje commented 2 years ago

Thanks applied, although in this case I don't feel we should abandon the smoke if we cannot set the local-patch thing. I,ve changed that into a carp()

abeltje / Test-Smoke

Fix modification of patchlevel.h #69