search

abemassry / wsend-gpg

Encrypted end to end file transfer
https://wsend.net
GNU General Public License v3.0
106 stars 4 forks source link

curl commands in install.sh failing #4

Closed phipolis closed 10 years ago

phipolis commented 10 years ago

Was trying to figure out why the install.sh script wasn't working on a Fedora 20 box. Traced it to the curl commands not resulting in the file being created:

wsend-gpg/install.sh uses this curl command, which fails: curl -o $HOME/.wsend/wsend https://raw.github.com/abemassry/wsend/master/wsend 2>/dev/null wsend/install.sh uses this curl command, which works: curl -L -s -o $wsend_base/wsend https://raw.github.com/abemassry/wsend/master/wsend

This may vary by implementation but on my system curl fails to find the file without -L.

abemassry commented 10 years ago

This bug was due to github changing their url from raw.github.com to raw.githubusercontent.com and I never updated the files. Thanks for spotting this. This commit bf446863ecc664b2895a0fc3a1c76ca36c6e74d2 should fix the issue, I've tested it and it seems to work. I've also added the curl -L option as you've mentioned which follows the links if they ever change it again and redirect like they currently do for future maintainability.

Thanks, Abe