search

abemassry / wsend

wsend: The opposite of wget
https://wsend.net
GNU General Public License v3.0
77 stars 8 forks source link

Allow directory upload #2

Closed vannell closed 10 years ago

vannell commented 10 years ago

Transmit directory thanks to tar and bzip2

As wsend take a mandatory filename to upload (cannot pipe from a tar command), I find it can be useful to pass a directory name to fully send and avoid to create_tar/wsend_it/rm_tar_file.

vannell commented 10 years ago

Make a bunch of corrections and simplification in all your codebase. It will improve its readability and its maintainability for future.

I make all this work in a separate branch (see my improve branch), but merge it to early in my master one and push remote. I hope it will not be a problem for you if you are interested in this evolution.

abemassry commented 10 years ago

Thank you for the code submission. I had one question about the install script, while it is redundant, it provided an easy one liner that people could copy and paste to install. With these changes what would that look like with no install script?

Something like:

wget https://raw.github.com/abemassry/wsend/master/wsend -O - | bash
vannell commented 10 years ago

You are right. With this way, you can completely forget an independent install script.

Maybe it would be more user friendly to display a custom message for the first time install instead of finishing with "error" like usage message. But for instance, it works properly.

The minor error that could happen is if user don't have curl at installation time, it will have to install curl and relaunch install command, but it seems normal to relaunch installation if a dependence is not met.