Fix for #11 and rubocop warnings

abemedia / jekyll-pdf

Create PDFs from Jekyll pages & documents.

http://abemedia.co.uk/jekyll-pdf/

GNU General Public License v3.0

104 stars 35 forks source link

Fix for #11 and rubocop warnings #14

Closed zhulik closed 5 years ago

mcrosson commented 6 years ago

This isn't strictly necessary

{{ content | markdownify }} will solve the issue of markdown not being rendered by the plugin

abemedia commented 6 years ago

Hi @zhulik, thanks for your contribution and sorry for keeping it waiting. Looks good but will manually test this before merging in. Will be merged in by the weekend.

mcrosson commented 6 years ago

@abeMedia I ran into troubles with custom PDF headers/footers with this branch.

The page.render() call seems to be causing it to use the HTML version of the page rather than any local adjustments for header/footer.

abemedia commented 6 years ago

I noticed you're using page.render, rather than self.render. Maybe something to do with that? (just a wild guess without going into detail)