search

abemedia / jekyll-pdf

Create PDFs from Jekyll pages & documents.
http://abemedia.co.uk/jekyll-pdf/
GNU General Public License v3.0
104 stars 35 forks source link

Fix for #7: remove jekyll-assets as a hard dependency #17

Closed mneumegen closed 3 months ago

mneumegen commented 6 years ago

try_require is a jekyll-assets method. Using jekyll-pdf without jekyll-assets will error because of this. This PR has the same intended behaviour but won't error if jekyll-assets isn't installed.

mneumegen commented 6 years ago

@abeMedia any chance we could get this merged in? It's a small change and makes a big difference for people getting started.

iamsebastian commented 5 years ago

Would you please just press the merge button and create a new release, @abeMedia ?

cjauvin commented 5 years ago

It's late March 2019, I'm a Jekyll newbee and I'm running into this error, which I don't know how to deal with.

harsh183 commented 5 years ago

Adding gem "jekyll-assets" didn't fix the problem, anything else we have to add?

KrzysztofKarol commented 5 years ago

@harsh183 Add gem "jekyll-assets", '~> 2' to Gemfile and - jekyll-assets to plugins in _config.yml

Source: https://github.com/abeMedia/jekyll-pdf/issues/7#issuecomment-347688752