abemedia / shareCount

A PHP script to fetch the count of social shares, cache the results and output as JSON, JSONP or XML data.
GNU General Public License v2.0
100 stars 35 forks source link

why are the entries for database access in the config file? #15

Closed propertunist closed 9 years ago

propertunist commented 9 years ago

as far as i am seeing, the database credentials supplied in the config file are never used anywhere in the code - did i miss something?

abemedia commented 9 years ago

It is because I was going to integrate stats using a database back-end at the time but then ended up rewriting the whole API in Golang for performance reasons. So to answer your question: no, they serve no purpose.

Maybe I will still integrate it if the demand is there but since this script is no longer used in our business it's currently not very likely.

propertunist commented 9 years ago

oh ok, no problem; i was just wanting to understand the code and that caused me to scratch my head a while. ;)