search

abenz1267 / walker

Application launcher similar to Rofi etc. . Wayland native.
MIT License
263 stars 12 forks source link

Move nix files into a nix directory #16

Closed schromp closed 5 months ago

schromp commented 5 months ago

The top level directory is getting quite cluttered with nix files. Even more so if my module pr gets merged. It may make sense to move more files into a nix/ directory.

One downside i can see is that having the default.nix (for the package) and the shell.nix for developing inside the nix folder would make it more cumbersome for non flake users. However, this repo is only packaged in flakes at the moment so most/all of the people that would utilize these files can do so through the flake.

As @diniamo is the one who implemented all the nix things until now he might have an opinion about this.

diniamo commented 5 months ago

No, I prefer to have it this way, especially until we don't have a home-manager module.

I imagine there might be edge cases where having the package as defaul.nix, and the shell as shell.nix is helpful.

diniamo commented 5 months ago

Ah, your pr adds the home-manager module... well I'd prefer to have only that in a separate directory.

schromp commented 5 months ago

Sounds good :)

abenz1267 commented 5 months ago

closed by #15