abenz1267 / walker

Application launcher similar to Rofi etc. . Wayland native.
MIT License
263 stars 12 forks source link

Many icons missing?! #25

Closed RoccoRakete closed 4 months ago

RoccoRakete commented 4 months ago

There are many icons missing in the applications list. I don't know if it has anything to do with these errors?!

Screenshot_29-03-24_12-13

abenz1267 commented 4 months ago

You need to provide more information:

(the errors in console are irrelevant)

RoccoRakete commented 4 months ago

If it's relevant, anyrun and wofi are working fine.

Let me know if you need anything else!

abenz1267 commented 4 months ago

Both anyrun and wofi are GTK3. Walker is GTK4.

I've installed the GTK theme and icon theme.. also installed boxbuddy and geary. No problems.

I've changed the way icons are loaded in order to catch errors... can you checkout the latest version, start via terminal and see if there's an icon-related error showing up?

This issue only seems to affect Nix users... on Arch stuff is fine.

RoccoRakete commented 4 months ago

Not fixed unfortunately.

Screenshot_29-03-24_14-40

abenz1267 commented 4 months ago

I've just pushed an update letting you explicitly set an icon theme... can you try that? I don't know what kinda problem nix and gtk4 have with icons....

"icons": {
"theme": "<theme>"
}
RoccoRakete commented 4 months ago

Still the same.

image

abenz1267 commented 4 months ago

Ok, can u do this for me? Put the following into example.c:

#include <gtk/gtk.h>

static void
activate (GtkApplication* app,
          gpointer        user_data)
{
  GtkWidget *window;
  GtkWidget *icon;
GtkWidget *box;

    icon = gtk_image_new_from_icon_name ("org.gnome.Geary");

  window = gtk_application_window_new (app);

box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
  gtk_window_set_child (GTK_WINDOW (window), box);
    gtk_box_append (GTK_BOX (box), icon);

  gtk_window_set_title (GTK_WINDOW (window), "Window");
  gtk_window_set_default_size (GTK_WINDOW (window), 200, 200);
  gtk_window_present (GTK_WINDOW (window));
}

int
main (int    argc,
      char **argv)
{
  GtkApplication *app;
  int status;

  app = gtk_application_new ("org.gtk.example", G_APPLICATION_DEFAULT_FLAGS);
  g_signal_connect (app, "activate", G_CALLBACK (activate), NULL);
  status = g_application_run (G_APPLICATION (app), argc, argv);
  g_object_unref (app);

  return status;
}

compile it via: gcc $( pkg-config --cflags gtk4 ) -o example example.c $( pkg-config --libs gtk4 ) .

Run ./example.

This should show the geary icon.

RoccoRakete commented 4 months ago

Sure. But I'm getting this.

EDIT: In case you can't see this: It's the same placeholder symbol, as shown by walker.

Screenshot_29-03-24_19-01

abenz1267 commented 4 months ago

Yeah, ok... for me this is good news: the issue is not related to Walker. I'm sorry.

Guess you need to ask Nix people why it's broken.

Closing, as it's not related to Walker.

RoccoRakete commented 4 months ago

Okay, so maybe @diniamo knows this? Since he packaged it for nix?

diniamo commented 4 months ago

It shouldn't have anything to do with the Nix package. I have no idea.

If walker uses the builtin methods of gtk, or some xdg library, I can't help you.

abenz1267 commented 4 months ago

@RoccoRakete you should open an issue with Nix (github? their forum?) and provide the little C example from above.

RoccoRakete commented 4 months ago

Yes, I already opened an issue with this discussion linked.

abenz1267 commented 4 months ago

Can you link it here so i can follow? There'll be more users and having a place to point them to would be good.

RoccoRakete commented 4 months ago

It's over at the nixOS Discord ID is: 1223334083556409555