Nix-related fixes - Githubissues

abenz1267 / walker

Application launcher similar to Rofi etc. . Wayland native.

MIT License

263 stars 12 forks source link

Nix-related fixes #26

Closed eclairevoyant closed 4 months ago

eclairevoyant commented 4 months ago

Changes:

correct callPackage misuse
wrap walker (fixes #25)
use reproducible source path (see https://nix.dev/guides/best-practices#reproducible-source-paths)

Also, heads up that I noticed that vendorHash is set for the package, which would need to be updated if the go dependencies change. (Alternatively it could be set to null, but that'd require vendoring the deps.)

diniamo commented 4 months ago

Hey, I'm the original author of the nix flake. I realized the callPackage misuse part at some point, but didn't have the time to fix it, nor did I know about inputsFrom - so thanks.

I have a question though, what does wrapGApps do?

eclairevoyant commented 4 months ago

See https://nixos.org/manual/nixpkgs/stable/#sec-language-gnome