search

aberant / osc-ruby

Open Sound Control Library for Ruby
MIT License
94 stars 16 forks source link

Fix parens for warning in Ruby 2.6.5 #15

Closed xavriley closed 4 years ago

xavriley commented 4 years ago

Small chance to fix an extra space in the method definition - def eof? () => def eof?() (without space)

Fixes the warning

/.gem/ruby/2.6.5/gems/osc-ruby-1.1.3/lib/osc-ruby/network_packet.rb:15: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument

Arguably the empty parens for methods like this could be removed but that's more of a stylistic thing across the whole project.

aberant commented 4 years ago

Great! Thanks for noticing that warning. I wish there was a way to make the build fail when there were warnings.