abersheeran / asgi-ratelimit

A ASGI Middleware to rate limit
Apache License 2.0
292 stars 11 forks source link

Added isort flake8 and their respective config, and blake + fixes #25

Closed euri10 closed 3 years ago

euri10 commented 3 years ago

Modified CI to add black/isort/flake8 Modified also in adding coverage / removing pytest-cov (it's possible to debug with pytest-cov in pycharm but I always end up being frustrated by the user experience, see https://stackoverflow.com/a/40906766 )

the last commit I would prefer you double triple check, coverage indicated that if user is None and group is None: was never False, which seems correct since we initialized it a few lines above with user, group = None, None So I removed those lines and indented correctly, seems ok to me but maybe there was a reason you wrote this in the first place ?