search

abersheeran / asgi-ratelimit

A ASGI Middleware to rate limit
Apache License 2.0
302 stars 13 forks source link

docs: custom block needs to be adapted #30

Closed euri10 closed 3 years ago

euri10 commented 3 years ago

I think since the newest release 0.5.1 the https://github.com/abersheeran/asgi-ratelimit#custom-block-handler is not correct anymore. I'm not sure about it but it seems to me it has to be adapted to the new setup, at least I had to do it today at work on mine

I'll try to come up with a test and change docs when time permits if someone doesnt figure it out before L_)

abersheeran commented 3 years ago

Ah, this is my negligence. Thanks for pointing out.

After you test and fix the document, if you think it is okay, you only need to publish a new tag 0.5.2, and the GitHub action will automatically push the new package to PyPi.

abersheeran commented 3 years ago

if you think it is okay, you only need to publish a new tag 0.5.2, and the GitHub action will automatically push the new package to PyPi.

Supplement: You can use python script/upload.py to ensure that __version__.py, pyproject.toml and git tags are updated at the same time.