search

abertschi / ad-free

A modularized audio ad blocker for Android
https://abertschi.ch/blog/2022/building-adfree/
Apache License 2.0
273 stars 19 forks source link

"Play until end" - funny but confusing #48

Closed kojid0 closed 4 years ago

kojid0 commented 4 years ago

I really like that some developers try to put some funny features into their apps. Really appreciate them making me smiling. But I don't understand "Play until end" option...

There should be two options only: "play local music file until spotify ad ends" or "play until end of music file, regardless if spotify ad already ended before".

abertschi commented 4 years ago

"play until end" plays the local audio track until its end. If it is set to yes (or any equivalent word), it plays local music until the end of the local audio track, regardless if ads have already ended. Spotify is only unmuted once local audio finishes. if it is set to no, Spotify is unmuted as soon as a detector detects no more ads. yes and no options alternate after each click.

abertschi commented 4 years ago

While I appreciate your feedback I am currently not planning to change this behavior.

abertschi commented 4 years ago

fixed in version #52

kojid0 commented 4 years ago

fixed in version #52

Thank you so much! I very appreciate your work 🙏