search

abertschi / ad-free

A modularized audio ad blocker for Android
https://abertschi.ch/blog/2022/building-adfree/
Apache License 2.0
273 stars 19 forks source link

Matching Rules for 'Generic Text Detector' #83

Open abertschi opened 2 years ago

famewolf commented 2 years ago

Can you provide an example from one of the supported services to use as a model or allow use to view the keyword search for the supported services in the app?

abertschi commented 2 years ago

Can you provide an example from one of the supported services to use as a model or allow use to view the keyword search for the supported services in the app?

https://abertschi.github.io/ad-free/troubleshooting/troubleshooting.html#generic-text-detector

famewolf commented 2 years ago

Ok...I wondered because accuradio is still giving it's tiny " always free" ads..so I added "com.slipstream.accuradio" and "will resume" to the general ad section.

abertschi commented 2 years ago

Ok...I wondered because accuradio is still giving it's tiny " always free" ads..so I added "com.slipstream.accuradio" and "will resume" to the general ad section.

Do you happen to have it granted unnecessary permission such as microphone? I know of a case that got resolved once we removed all permissions from accuradio.

famewolf commented 2 years ago

The only permission it had was for "nearby devices". It ignored my general filter even after I watched and changed it to "Music will resume shortly" which is exact message displayed during their 5 second or less "accuradio is free and always will be" ads.

abertschi commented 2 years ago

The only permission it had was for "nearby devices". It ignored my general filter even after I watched and changed it to "Music will resume shortly" which is exact message displayed during their 5 second or less "accuradio is free and always will be" ads.

Seems that the issue is device specific. the general filter will likely not work in this app as they build a custom widget to draw content on the notification. Consider creating a recording dump as described here https://abertschi.github.io/ad-free/troubleshooting/troubleshooting.html#org4d393d1 with Accuradio tracer and submit the dump.

famewolf commented 1 year ago

The only permission accuradio has on this device is "nearby devices". I do have the phone linked to a bluetooth soundbar but the notifications still show as expected when ads play unlike when I stream to a google hub (google's version of an echo show)

On Wed, Aug 24, 2022 at 5:21 PM Andrin Bertschi @.***> wrote:

Ok...I wondered because accuradio is still giving it's tiny " always free" ads..so I added "com.slipstream.accuradio" and "will resume" to the general ad section.

Do you happen to have it granted unnecessary permission such as microphone? I know of a case that got resolved once we removed all permissions from accuradio.

— Reply to this email directly, view it on GitHub https://github.com/abertschi/ad-free/issues/83#issuecomment-1226378873, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCY74H3FCEGWRSBH62CJQTV22G5BANCNFSM56SHQTVA . You are receiving this because you commented.Message ID: @.***>

unseenlarks commented 10 months ago

i've been having this same issue on a moto g32, running Android 12. checked for unnecessary permissions, and used the generic text detector filter, just like famewolf. the Accuradio tracer generated this file. adfree-accuradio.txt

edit: tested what happened when 'best effort detector', which i'd forgotten about, was enabled. these 'music will resume shortly' ads still get through.

abertschi commented 10 months ago

i've been having this same issue on a moto g32, running Android 12. checked for unnecessary permissions, and used the generic text detector filter, just like famewolf. the Accuradio tracer generated this file. adfree-accuradio.txt

Thank you for the dump, with the dump we can easily add a rule for this case. Will do it next time I find the time to release a new update :+1: .

unseenlarks commented 10 months ago

thank you very much!

unseenlarks commented 9 months ago

hello again. sadly i don't see any changes on v3.2. i have added a generic text detector again for com.slipstream.accuradio / as "music will resume shortly", and the app has been granted the permissions it asks for. do i need to try anything else, in case this is user error? thank you.

another thing, it doesn't show a notification even if 'always-on notification is enabled'. the app does work, as tapping the music note on the second screen mutes audio, and fires the 'ad detected' notification.

the device now runs Android 13, so i had to enable permissions (allow 'restricted settings'), so i could fully grant them to the app.

also i use the device in dark mode and the smaller notifications the app gives (for example when enabling developer mode, then a tracer for a specific app), are hard to read.

adfree-accuradio.txt

abertschi commented 9 months ago

hello again. sadly i don't see any changes on v3.2. i have added a generic text detector again for com.slipstream.accuradio / as "music will resume shortly", and the app has been granted the permissions it asks for. do i need to try anything else, in case this is user error? thank you.

another thing, it doesn't show a notification even if 'always-on notification is enabled'. the app does work, as tapping the music note on the second screen mutes audio, and fires the 'ad detected' notification.

the device now runs Android 13, so i had to enable permissions (allow 'restricted settings'), so i could fully grant them to the app.

also i use the device in dark mode and the smaller notifications the app gives (for example when enabling developer mode, then a tracer for a specific app), are hard to read.

adfree-accuradio.txt

@unseenlarks Thanks for the new recording. Let's move this conversation to here: https://github.com/abertschi/ad-free/issues/93