abertschi / ad-free

A modularized audio ad blocker for Android
https://abertschi.ch/blog/2022/building-adfree/
Apache License 2.0
277 stars 19 forks source link

F-Droid build failed #85

Closed linsui closed 2 years ago

linsui commented 2 years ago
> Task :app:lintVitalRelease FAILED
/builds/2/fdroiddata/build/ch.abertschi.adfree/app/build.gradle:10: Error: Google Play requires that apps target API level 30 or higher.
 [ExpiredTargetSdkVersion]
        targetSdkVersion 27
        ~~~~~~~~~~~~~~~~~~~
   Explanation for issues of type "ExpiredTargetSdkVersion":
   As of the second half of 2018, Google Play requires that new apps and app
   updates target API level 26 or higher.
   Configuring your app to target a recent API level ensures that users
   benefit from significant security and performance improvements, while still
   allowing your app to run on older Android versions (down to the
   minSdkVersion).
   To update your targetSdkVersion, follow the steps from "Meeting Google Play
   requirements for target API level",
   https://developer.android.com/distribute/best-practices/develop/target-sdk.
   html
   https://support.google.com/googleplay/android-developer/answer/113469#targetsdk
   https://developer.android.com/distribute/best-practices/develop/target-sdk.html
1 errors, 0 warnings
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Lint found fatal errors while assembling a release target.

  Fix the issues identified by lint, or create a baseline to see only new errors:

android { lint { baseline = file("lint-baseline.xml") } }


  For more details, see https://developer.android.com/studio/write/lint#snapshot

Could you please take a look? Thanks!

licaon-kter commented 2 years ago

Fixed for F-Droid like this https://gitlab.com/fdroid/fdroiddata/-/commit/71c434afb4bb71f18a436465046d4695e5ad5738

@abertschi maybe this can be integrated here in the code instead?

abertschi commented 2 years ago

thanks for the ping. I added the fix :+1:

abertschi commented 2 years ago

https://github.com/abertschi/ad-free/commit/95e3723f7136a63979133d7c328c989794052d31

linsui commented 2 years ago

Thanks!

licaon-kter commented 2 years ago

Done https://gitlab.com/fdroid/fdroiddata/-/commit/2db9f5463b37619b18f65935c28a2448e3e27890

abertschi commented 2 years ago

thanks