search

abertschi / water-me

Don't forget to water your plants.
GNU General Public License v3.0
56 stars 10 forks source link

Issues with camera view #17

Open spl opened 1 year ago

spl commented 1 year ago

When I first went to take a picture, I couldn't find the trigger button. It was only by accident that I discovered it when I dragged my finger up from the bottom to the top. When I did take a picture, I noticed that the top of the picture I took was not visible in the camera view while the button was visible at the bottom. I suspect there's something funny about the vertical dimension of the camera view on my phone (Moto G5 Plus, Android 8.1.0), because I don't think you would make it necessary to scroll to get to the button.

Let me know if there's more information I can provide to help.

abertschi commented 1 year ago

This is currently by design. I do not crop the view, but rather scale it such that it fits the width. I agree a crop would be better so we can show the button within the viewport :)

cyberme0w commented 1 year ago

Hi there!

I also ran into this issue when first trying out the app. I think an easy way of getting this working (i.e. scaling everything to fit in the screen) would be to replace the SingleChildScrollView with a regular Column and instead have the children adapt to the space available with Flexible. I've made a quick edit to the code, just to see if it works as I expected, and this is how it looks on my device:

I'll try cleaning up a bit (some margins would be nice, to avoid overlapping the status bar, as well as touching the button below) and see if there are any other guidelines I might have missed and can send a PR later.