search

abesamma / giscus-for-tiddlywiki-demo

Demo of a commenting system for TiddlyWiki powered by Github discussions via Giscus app
0 stars 0 forks source link

It's possible to create new gh-discussions that will not show up on the wiki page again #7

Open pmario opened 1 year ago

pmario commented 1 year ago

I did 2 test

  1. Create a new tiddler and start a discussion with it, using the wiki.

    • 5

  2. I did start a new discussion here at GH, which does not show up at the wiki.

    • 6

I think there are several ways to resolve this ... Just my thoughts

IMO a comment system should stay on focus. So for tiddlers in the wiki, which contain content it should be possible to create new comments. ... That's what it is designed for.

Creating new tiddlers and start comments IMO is questionable. ... Since the author of the wiki will like to get specific feedback per tiddler. So discussion titles and tiddler titles will have to match.

I think it should not be possible to create a new tiddler at the wiki and then start a discussion with it -- because the tiddler content cannot be saved back. -> So there is a chance that some info has been lost.

IMO creating a discussion here at GitHub about the wiki in general as a general medium for feedback should also show up on a summary page in the wiki.

eg: There are some more "probably" off-topic discussions at XXX ...

For some wiki authors this may be desirable, for some it may be not.

As I said. Just some thoughts Thanks for creating the test wiki and the plugin.

abesamma commented 1 year ago

Hi @pmario thanks for your extremely valuable contribution as always. I'm actually aware of the first problem and this is due to a limitation imposed on me by Giscus' API implementation. I agree that readers shouldn't be able to start discussions from the wiki. I'm still trying to figure out how to plug that hole. There will probably be some untidy hacking involved.

The second problem is new to me. It's strange but it may have something to do with the Giscus bot's inability to access discussion threads that it didn't create itself. Again, this is probably a limitation imposed by Giscus' API and I'll have to figure that out too. I'll add this to the list of issues known to follow up later. Hopefully I might be able to solve these in time for the release in early March.

Thank you again for your help!

pmario commented 1 year ago

From your initial post at Talk https://talk.tiddlywiki.org/t/giscus-for-tiddlywiki/6247 I was not aware, that you actually created a plugin connected with the Giscus API. ...

Only as TT https://talk.tiddlywiki.org/t/giscus-for-tiddlywiki/6247/4 posted a complain about feedback .. or the "lack thereof" I did have a closer look.

IMO if you would remove the UI elements that allow users to create tiddlers this would be enough for the beginning.

Having a discussion button below missing tiddlers should be solvable with the view-template cascade.

abesamma commented 1 year ago

Thank you @pmario. I really appreciate the help and feedback. Yes, the view template cascade should help nicely with the missing tiddler issue, and hiding the new tiddler controls should be sufficient for the time being. I agree 💯.

On Mon, Feb 27, 2023, 16:35 Mario Pietsch @.***> wrote:

From your initial post at Talk https://talk.tiddlywiki.org/t/giscus-for-tiddlywiki/6247 I was not aware, that you actually created a plugin connected with the Giscus API. ...

Only as TT https://talk.tiddlywiki.org/t/giscus-for-tiddlywiki/6247/4 posted a complain about feedback .. or the "lack thereof" I did have a closer look.

IMO if you would remove the UI elements that allow users to create tiddlers this would be enough for the beginning.

Having a discussion button below missing tiddlers should be solvable with the view-template cascade.

— Reply to this email directly, view it on GitHub https://github.com/abesamma/giscus-for-tiddlywiki-demo/issues/7#issuecomment-1446656048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6NVYSXQYVH45WPXW4BOE3WZTJTJANCNFSM6AAAAAAVJFMDEA . You are receiving this because you commented.Message ID: @.***>

pmario commented 6 months ago

@abesamma -- IMO you should delete the spam post and report the spam

abesamma commented 6 months ago

@abesamma -- IMO you should delete the spam post

Thanks. I never noticed it. That's something to think about.