abess-team / abess

Fast Best-Subset Selection Library
https://abess.readthedocs.io/
Other
474 stars 41 forks source link

consider weights in Ordinal model #459

Closed bbayukari closed 2 years ago

bbayukari commented 2 years ago

After checking, I found that weights are not used in the Ordinal model. Thus, I consider weights and modify some code.

codecov[bot] commented 2 years ago

Codecov Report

Base: 93.45% // Head: 93.45% // No change to project coverage :thumbsup:

Coverage data is based on head (6a9fdeb) compared to base (e25543a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #459 +/- ## ======================================= Coverage 93.45% 93.45% ======================================= Files 29 29 Lines 3225 3225 ======================================= Hits 3014 3014 Misses 211 211 ``` | Flag | Coverage Δ | | |---|---|---| | Python | `89.74% <ø> (ø)` | | | rpackage | `95.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.