abess-team / abess

Fast Best-Subset Selection Library
https://abess.readthedocs.io/
Other
474 stars 41 forks source link

Unified GLM algorithm #461

Closed oooo26 closed 1 year ago

oooo26 commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Base: 93.45% // Head: 93.47% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (fd1061a) compared to base (9ddc47d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #461 +/- ## ========================================== + Coverage 93.45% 93.47% +0.01% ========================================== Files 29 29 Lines 3225 3232 +7 ========================================== + Hits 3014 3021 +7 Misses 211 211 ``` | Flag | Coverage Δ | | |---|---|---| | Python | `89.80% <100.00%> (+0.05%)` | :arrow_up: | | rpackage | `95.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/abess-team/abess/pull/461?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team) | Coverage Δ | | |---|---|---| | [python/abess/linear.py](https://codecov.io/gh/abess-team/abess/pull/461/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-cHl0aG9uL2FiZXNzL2xpbmVhci5weQ==) | `99.14% <ø> (ø)` | | | [python/abess/bess\_base.py](https://codecov.io/gh/abess-team/abess/pull/461/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-cHl0aG9uL2FiZXNzL2Jlc3NfYmFzZS5weQ==) | `98.82% <100.00%> (+0.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Mamba413 commented 1 year ago

It would be better if you could document the changes in the change log https://abess.readthedocs.io/en/latest/Changelog.html after it is merged.

oooo26 commented 1 year ago

Sure, I will update both the change log and development guide later.