abess-team / abess

Fast Best-Subset Selection Library
https://abess.readthedocs.io/
Other
474 stars 41 forks source link

test: change test in R #481

Closed bbayukari closed 1 year ago

bbayukari commented 1 year ago

Comparing these two results is not a good choice, because spca_fit2 doesn't know the sample size so the gsection tune path will be different.

spca_fit1 <- abesspca(USArrests, tune.path = "gsection"

spca_fit2 <- abesspca(cov(USArrests) * (nrow(USArrests) - 1) / nrow(USArrests),
  type = "gram", tune.path = "gsection"
)

Actually, the path of spca_fit1 is "2,3,2,3,4" and the path of spca_fit1 is "2,3,2". Thus, I add gs_range = c(1,3) to correct it.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.72% // Head: 97.72% // No change to project coverage :thumbsup:

Coverage data is based on head (266420f) compared to base (7d2bd24). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #481 +/- ## ======================================= Coverage 97.72% 97.72% ======================================= Files 7 7 Lines 968 968 ======================================= Hits 946 946 Misses 22 22 ``` | Flag | Coverage Δ | | |---|---|---| | Python | `97.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.