abess-team / abess

Fast Best-Subset Selection Library
https://abess.readthedocs.io/
Other
474 stars 41 forks source link

fix some fails test in R #487

Closed bbayukari closed 1 year ago

bbayukari commented 1 year ago
  1. Now, our setting of gamma model (Xb<0) is different from glm (Xb>0), so I change the code for verifying gamma model results.
  2. CV may not be a good strategy in PCA, so I delete the test "abesspca (FPC-CV) works".
  3. avoid the warning: 'nrow', 'ncol', disregarded for [mM]atrix 'data'.
codecov[bot] commented 1 year ago

Codecov Report

Base: 97.72% // Head: 95.42% // Decreases project coverage by -2.31% :warning:

Coverage data is based on head (86621f7) compared to base (66f1108). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #487 +/- ## ========================================== - Coverage 97.72% 95.42% -2.31% ========================================== Files 7 27 +20 Lines 969 2995 +2026 ========================================== + Hits 947 2858 +1911 - Misses 22 137 +115 ``` | Flag | Coverage Δ | | |---|---|---| | Python | `97.72% <ø> (ø)` | | | rpackage | `94.32% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team) | Coverage Δ | | |---|---|---| | [R-package/R/abess.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvYWJlc3MuUg==) | `99.55% <100.00%> (ø)` | | | [R-package/R/generate.spc.matrix.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvZ2VuZXJhdGUuc3BjLm1hdHJpeC5S) | `0.00% <0.00%> (ø)` | | | [R-package/R/generate.matrix.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvZ2VuZXJhdGUubWF0cml4LlI=) | `94.33% <0.00%> (ø)` | | | [R-package/R/predict.abess.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvcHJlZGljdC5hYmVzcy5S) | `98.30% <0.00%> (ø)` | | | [R-package/R/utility.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvdXRpbGl0eS5S) | `85.91% <0.00%> (ø)` | | | [R-package/R/deviance.abess.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvZGV2aWFuY2UuYWJlc3MuUg==) | `94.73% <0.00%> (ø)` | | | [R-package/R/abessrpca.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvYWJlc3NycGNhLlI=) | `100.00% <0.00%> (ø)` | | | [R-package/R/print.abesspca.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvcHJpbnQuYWJlc3NwY2EuUg==) | `100.00% <0.00%> (ø)` | | | [R-package/R/print.abess.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvcHJpbnQuYWJlc3MuUg==) | `100.00% <0.00%> (ø)` | | | [R-package/R/plot.abess.R](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-Ui1wYWNrYWdlL1IvcGxvdC5hYmVzcy5S) | `93.10% <0.00%> (ø)` | | | ... and [11 more](https://codecov.io/gh/abess-team/abess/pull/487?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.