search

abessifi / pyatta

A python REST API to configure and manage vyatta/vyos router.
GNU General Public License v3.0
20 stars 14 forks source link

bug when running commit cmd #7

Closed mootezbessifi closed 10 years ago

mootezbessifi commented 10 years ago

when you try to commit some new added configs and something wrong happened, -run() method in utils.py have to rise an exception and executes the following lines: except subprocess.CalledProcessError: out = False logger.debug('command output: %s', out) return ' '.join(out.splitlines())

in this case "out" is a boolean variable that doesn't have splitelines as appropriate method

abessifi commented 10 years ago

Thanks for reporting the bug. The issue is now fixed : https://github.com/vaytess/pyatta/commit/92c8feb44a7f22e25c3a20d15125d1398b2da6eb You can pull and run tests/test_config_session.py unittests to be sure ;)