search

abesto / ams2-career

https://ams2-career.abesto.net
The Unlicense
6 stars 1 forks source link

Disabled cross-discipline gains no XP anymore #54

Closed CaptainSlow72 closed 2 years ago

CaptainSlow72 commented 2 years ago

Describe the bug When cross-discipline is unchecked, no XP is gained anymore.

To Reproduce Steps to reproduce the behavior:

  1. Uncheck cross-discipline in settings tab
  2. Record a race. No XP are gained anymore for this discipline.

Expected behavior XP are gained after recording a race for this discipline, but not for any other disciplines.

abesto commented 2 years ago

Omg. Guess I only checked that there was no cross-discipline gain, and never checked that there is gain in the same discipline. Should be a simple fix (he said, confidently...) Thank you for the report.

abesto commented 2 years ago

Fix should be live in a few minutes. @all-contributors let's add @CaptainSlow72 to the contributors list for bug reports as well, while we're at it.

allcontributors[bot] commented 2 years ago

@abesto

I've put up a pull request to add @CaptainSlow72! :tada:

abesto commented 2 years ago

@CaptainSlow72 Fix has rolled out, and AFAICT it's now working as intended. Feel free to reopen if something is still off. (A changelog popup on reload will tell you that you actually got the new version loaded)

CaptainSlow72 commented 2 years ago

Successfully tested. Seems to work as intended now. Thanks for the fast fix.