search

abesto / ams2-career

https://ams2-career.abesto.net
The Unlicense
6 stars 1 forks source link

New Google Sheet for data, script to update data files from that #58

Closed abesto closed 2 years ago

abesto commented 2 years ago

I've spent some time creating a new Google Sheet that contains only and exactly the data used by this app, and some tooling to update the data in the app with one command. This should hopefully

@rsr427 I'd appreciate your eyes on, and thoughts about

I've published a preview version of the app using these new changes to https://d4sk2ytizwr62.cloudfront.net/ (same caveats as before: going directly to https://d4sk2ytizwr62.cloudfront.net/career won't work, but clicking through the menu from https://d4sk2ytizwr62.cloudfront.net/ will).

rsr427 commented 2 years ago

I owe you some eyes on the new input sheets.  My bad.  Work has picked up with travel in the last two weeks.  I'll try to check it out next week when I'm on vaca.  Also, looks like we have 3 new tracks coming out from Argentina.  We'll have to integrate those so I will have to update the matrix. Thanks, Ryan On Sunday, June 19, 2022 at 11:19:55 AM EDT, Zoltán Nagy @.***> wrote:

@abesto requested your review on: #58 New Google Sheet for data, script to update data files from that.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.Message ID: @.***>

rsr427 commented 2 years ago

Files look clean. I updated the Track matrix with the new tracks both in this file and the old file. The old file could tell me how many classes would race at that track, which is helpful. It was copy and paste otherwise.

I used a video from RD to get the configuration names since I don't have AMS2 with me currently. I thought there were supposed to be multiple Cordoba configurations, but apparently we have one for now. I will update as more are released.

abesto commented 2 years ago

Lovely, thank you!

The old file could tell me how many classes would race at that track, which is helpful.

~If that's good enough for you, a new tab in the new sheet would be a safe way to do this - another tab won't confuse the automation.~

Update, later: I've added a new sheet called [#(Car Classes) / Track] with this.

I updated the Track matrix with the new tracks both in this file and the old file.

Nice, I'll pull those in, time to see the automation in action! :D

I used a video from RD to get the configuration names since I don't have AMS2 with me currently.

Hah, I'll double-check then just in case.

abesto commented 2 years ago

Differences I see between the sheet and the sim:

rsr427 commented 2 years ago

Differences I see between the sheet and the sim:

Buenos Aires has a "No.6 S" layout that's currently missing from the sheet. Shall I add it in, with the same classes as the No.6 layout? (or leave it to you)

Definitely include it. I'm not sure what the layout is and that usually drove what series raced there. If it's a smaller track, I usually only include National type series, whereas larger layouts are for more international series. If the layout difference is a chicane, it could probably be the same.

The Buenos Aires layouts in-game don't seem to have the human-friendly names in parentheses, like (Modern). Shall we drop them to avoid confusion? Or keep them in for extra information? Where do they even come from?

They come from my little brain and what I know about the tracks history. I thought they might help the user pick the right track in-game, but the names of the layouts are probably clear enough. It was probably more helpful to me than for other people.

The circuit name for Buenos Aires seems to be "Buenos Aires Circuito". I'd probably opt for using that full name.

Use the full name, for sure.

Note that the default "Group By Location" in-game actually groups by location / city. Most of the time the city is a prefix of the name of the circuit, but not always. For example under Granja Viana we have both "Copa Sao Paulo Kart Stage 2" (note the complete lack of "Granja Viana" in the track name) and Granja Viana Kart 101. Unfortunately this means the current Track / Configuration setup we have is basically broken; my best idea is to transition to a Location / Configuration setup. By "broken" I mean that from "Copa Sao Paulo Kart Stage 2" there's no way in the game to find out that it's hidden under "Granja Viana". A problem for another day - just filed #59 for this.

I'll keep an eye out for a resolution. Fingered crossed for an API solution...

Cordoba does have additional layouts: No.2 and No.4. Shall I add them with the same classes as the TC layout? (or leave it to you)

This goes back to my National vs International layout ideology. I would honestly want to study what the layouts are used for. My bet is that the main layout is probably equivalent to the type of track that the Brazil Stock car series races in. For the smaller layouts, probably like the tracks I picked for the Club racing series. Does that make sense? But I can come back with a definitive answer.

Córdoba in-game has an accent on the first "o". By default I'd say let's include it (the app should be just fine, in theory, but I'll test). Do you actively think we should leave accents out instead? (Same for Termas de Río Hondo)

Dude, I don't know how to do the accents. But yes, I think that should be the case.

Sorry I can't highlight my responses neatly, I can't figure it out on this mail app...

⁣Get BlueMail for Android ​

On Jul 5, 2022, 3:37 PM, at 3:37 PM, "Zoltán Nagy" @.***> wrote:

Differences I see between the sheet and the sim:

  • Buenos Aires has a "No.6 S" layout that's currently missing from the sheet. Shall I add it in, with the same classes as the No.6 layout? (or leave it to you)
  • The Buenos Aires layouts in-game don't seem to have the human-friendly names in parentheses, like (Modern). Shall we drop them to avoid confusion? Or keep them in for extra information? Where do they even come from?
  • The circuit name for Buenos Aires seems to be "Buenos Aires Circuito". I'd probably opt for using that full name.
  • Note that the default "Group By Location" in-game actually groups by location / city. Most of the time the city is a prefix of the name of the circuit, but not always. For example under Granja Viana we have both "Copa Sao Paulo Kart Stage 2" (note the complete lack of "Granja Viana" in the track name) and Granja Viana Kart 101. Unfortunately this means the current Track / Configuration setup we have is basically broken; my best idea is to transition to a Location / Configuration setup. By "broken" I mean that from "Copa Sao Paulo Kart Stage 2" there's no way in the game to find out that it's hidden under "Granja Viana". A problem for another day - just filed https://github.com/abesto/ams2-career/issues/59 for this.
  • Cordoba does have additional layouts: No.2 and No.4. Shall I add them with the same classes as the TC layout? (or leave it to you)
  • Córdoba in-game has an accent on the first "o". By default I'd say let's include it (the app should be just fine, in theory, but I'll test). Do you actively think we should leave accents out instead? (Same for Termas de Río Hondo)

-- Reply to this email directly or view it on GitHub: https://github.com/abesto/ams2-career/pull/58#issuecomment-1175426242 You are receiving this because you were mentioned.

Message ID: @.***>

abesto commented 2 years ago

Buenos Aires No.6 S [...] If the layout difference is a chicane, it could probably be the same.

Yep, it's a chicane. Added to the sheet with the same classes as No.6!

Buenos Aires track / layout names: alright, I've just removed the human-friendly names in parentheses to match the game, and added the full name. While I was at it, I dropped the space between "No." and the number to completely match the in-game name (so "No.6", instead of "No. 6").

This goes back to my National vs International layout ideology. I would honestly want to study what the layouts are used for. My bet is that the main layout is probably equivalent to the type of track that the Brazil Stock car series races in. For the smaller layouts, probably like the tracks I picked for the Club racing series. Does that make sense? But I can come back with a definitive answer.

Yep, makes perfect sense! No.2 is a short layout, No.4 is the same as TC, just has ~2 extra turns (longer than a chicane). Would love if you could add these, make sure the classes make sense / are consistent with the other stuff we have.

Dude, I don't know how to do the accents. But yes, I think that should be the case.

Lol, ok :D My secret trick is plopping the name of the track into Google / Wikipedia, then copy-pasting from there :P Gave this a bit of thought, turns out it's a bit more involved than I initially thought: https://github.com/abesto/ams2-career/issues/60. For the moment, let's not add accents; I'll tackle this separately.

Sorry I can't highlight my responses neatly, I can't figure it out on this mail app...

Heh, no worries, it's pretty clear as is. FWIW, I'd expect emails to support Markdown as well, but have never actually tested this (so a quote would be: start the line with a > character)

rsr427 commented 2 years ago

We can use a simplistic assumption for the Buenos Aires for now. I'll work on a more accurate distribution across classes.

Another value-add we provide for the AMS2 community.

Thanks, Ryan

⁣Get BlueMail for Android ​

On Jul 6, 2022, 3:33 AM, at 3:33 AM, "Zoltán Nagy" @.***> wrote:

Buenos Aires No.6 S [...] If the layout difference is a chicane, it could probably be the same.

Yep, it's a chicane. Added to the sheet with the same classes as No.6!

Buenos Aires track / layout names: alright, I've just removed the human-friendly names in parentheses to match the game, and added the full name. While I was at it, I dropped the space between "No." and the number to completely match the in-game name (so "No.6", instead of "No. 6").

This goes back to my National vs International layout ideology. I would honestly want to study what the layouts are used for. My bet is that the main layout is probably equivalent to the type of track that the Brazil Stock car series races in. For the smaller layouts, probably like the tracks I picked for the Club racing series. Does that make sense? But I can come back with a definitive answer.

Yep, makes perfect sense! No.2 is a short layout, No.4 is the same as TC, just has ~2 extra turns (longer than a chicane). Would love if you could add these, make sure the classes make sense / are consistent with the other stuff we have.

Dude, I don't know how to do the accents. But yes, I think that should be the case.

Lol, ok :D My secret trick is plopping the name of the track into Google / Wikipedia, then copy-pasting from there :P Gave this a bit of thought, turns out it's a bit more involved than I initially thought: https://github.com/abesto/ams2-career/issues/60. For the moment, let's not add accents; I'll tackle this separately.

Sorry I can't highlight my responses neatly, I can't figure it out on this mail app...

Heh, no worries, it's pretty clear as is. FWIW, I'd expect emails to support Markdown as well, but have never actually tested this (so a quote would be: start the line with a > character)

-- Reply to this email directly or view it on GitHub: https://github.com/abesto/ams2-career/pull/58#issuecomment-1175881825 You are receiving this because you were mentioned.

Message ID: @.***>