search

abetlen / llama-cpp-python

Python bindings for llama.cpp
https://llama-cpp-python.readthedocs.io
MIT License
8.17k stars 974 forks source link

Fixed typo at line 340 of README.md #1791

Open Victoran0 opened 1 month ago

Victoran0 commented 1 month ago

Under the Chat Completion section, about the fourth line under it, we have: 'The model will will format the messages into a single prompt using the following order of precedence:'... 'will' appeared twice, this update fix that.

Victoran0 commented 1 month ago

The commit message / PR title could better match what it is! Deleting the typo / grammar issue has nothing to do with cuda.

Oops, sorry about that, I did use the same message as the latest commit the readme.md file has, with the additional (updated) at the end. That is because i thought the new commit is not a new feature, only fixing a typographical error. However, I have edited the commit message in a new commit.

lukestanley commented 1 month ago

But now there are 2 commit messages and none of them quite describe what someone would want to know. For example if someone saw the message: "Typo at line 340 fixed", they would think - what file? Then they might go to check the file and see that there is no change there at all. Empty commits are not so helpful. Instead, you might want to undo your last empty commit, and adjust the commit message in your original commit. You would probably then want to force push it up to overwrite Victoran0:patch-2 with a better commit message. @Victoran0

Victoran0 commented 1 month ago

@lukestanley how does it look now?

Victoran0 commented 1 month ago

Thanks for your consideration @lukestanley 👏👏👏