search

abetlen / llama-cpp-python

Python bindings for llama.cpp
https://llama-cpp-python.readthedocs.io
MIT License
8.17k stars 974 forks source link

Update README.md #1825

Open Nik-Kras opened 2 weeks ago

ExtReMLapin commented 2 weeks ago

Average 'I can't code but I want to be in the contributors list' PR

richdougherty commented 1 day ago

Hi @Nik-Kras, I think it's nice to keep the text clean. My suggestion is that I would probably go lighter on the changes and just stick to obvious grammar errors (The model will will format), and not just minor style changes. This is because the changes add extra diffs to the code which can make history harder to trace. If you stick to fixes it will also make it easier for the maintainer to merge.

I'm reminded of this first PR on a project I worked on, which got a bit famous with a blog post: https://github.com/playframework/playframework/pull/616. Hopefully that will encourage you.