search

abey79 / vpype

The Swiss-Army-knife command-line tool for plotter vector graphics.
https://vpype.readthedocs.io/
MIT License
702 stars 61 forks source link

Fix crash with Click 8.0 #273

Closed vmario89 closed 3 years ago

vmario89 commented 3 years ago

Hi, i updated some of my pip modules. Now i get the following warnings:

/home/tomate/.local/lib/python3.8/site-packages/vpype_cli/cli.py:126: DeprecationWarning: 'resultcallback' has been renamed to 'result_callback'. The old name will be removed in Click 8.1.
  @cli.resultcallback()
/home/tomate/.local/lib/python3.8/site-packages/vpype_cli/cli.py:108: DeprecationWarning: 'get_os_args' is deprecated and will be removed in Click 8.1. Access 'sys.argv[1:]' directly instead.
  cmd_string = "vpype " + " ".join(shlex.quote(arg) for arg in get_os_args()) + "\n"
Error in vpype:'int' object has no attribute 'lower'
abey79 commented 3 years ago

Thanks for reporting. Indeed, Click has released a new major version and there might be some change I need to do for compatibility.

abey79 commented 3 years ago

I can't directly reproduce this error, can you provide the full command which triggers it?

vmario89 commented 3 years ago

Hi. They are thrown when running https://gitea.fablabchemnitz.de/MarioVoigt/mightyscape-1.X/src/branch/master/extensions/fablabchemnitz/vpypetools/vpypetools.py from an inkscape extension call, like linesort

grafik

abey79 commented 3 years ago

I can reproduce now, and I see that it's actually a crash in addition to deprecation warnings. Working on it.

abey79 commented 3 years ago

The workaround it to use a pre-8 version of Click.