abey79 / vsvg

Fast and portable tools for plotter users
http://whisk.rs
MIT License
110 stars 13 forks source link

whisk.rs live demo crashes on Chromium browsers #154

Closed angelocarly closed 2 weeks ago

angelocarly commented 2 weeks ago

Issue

whisk.rs shows loading indicator and crashes.

Hardware + Software

Tested on Google Chrome 129.0.6668.60 and Vivaldi 6.9.3447.46
Mac Darwin 23.6.0 M1

Logs

using deprecated parameters for the initialization function; pass a single object instead
__wbg_init @ whiskers_web_demo.js:2743
whiskers_web_demo.js:464 [eframe::web::web_runner] eframe-0.28.1/src/web/web_runner.rs:39: eframe compiled without RUSTFLAGS='--cfg=web_sys_unstable_apis'. Copying text won't work.
(anonymous) @ whiskers_web_demo.js:464
whisk.rs/:1 Error while parsing WGSL: :196:1 error: missing return at end of function
}
^

 - While validating [ShaderModuleDescriptor "../shaders/line.wgsl"]
 - While calling [Device "egui wgpu device"].CreateShaderModule([ShaderModuleDescriptor "../shaders/line.wgsl"]).

whisk.rs/:1 Compilation log for [Invalid ShaderModule "../shaders/line.wgsl"]:
1 error(s) generated while compiling the shader:
:196:1 error: missing return at end of function
}
^

whisk.rs/:1 [Invalid ShaderModule "../shaders/line.wgsl"] is invalid.
 - While validating vertex stage ([Invalid ShaderModule "../shaders/line.wgsl"], entryPoint: vs_main).
 - While validating vertex state.
 - While calling [Device "egui wgpu device"].CreateRenderPipeline([RenderPipelineDescriptor "line pipeline"]).

whisk.rs/:1 Error while parsing WGSL: :83:1 error: missing return at end of function
}
^

 - While validating [ShaderModuleDescriptor "../shaders/point.wgsl"]
 - While calling [Device "egui wgpu device"].CreateShaderModule([ShaderModuleDescriptor "../shaders/point.wgsl"]).

whisk.rs/:1 Compilation log for [Invalid ShaderModule "../shaders/point.wgsl"]:
1 error(s) generated while compiling the shader:
:83:1 error: missing return at end of function
}
^

whisk.rs/:1 [Invalid ShaderModule "../shaders/point.wgsl"] is invalid.
 - While validating vertex stage ([Invalid ShaderModule "../shaders/point.wgsl"], entryPoint: vs_main).
 - While validating vertex state.
 - While calling [Device "egui wgpu device"].CreateRenderPipeline([RenderPipelineDescriptor "PointPainter pipeline"]).

whisk.rs/:1 Error while parsing WGSL: :83:1 error: missing return at end of function
}
^

 - While validating [ShaderModuleDescriptor "../shaders/point.wgsl"]
 - While calling [Device "egui wgpu device"].CreateShaderModule([ShaderModuleDescriptor "../shaders/point.wgsl"]).

whisk.rs/:1 Compilation log for [Invalid ShaderModule "../shaders/point.wgsl"]:
1 error(s) generated while compiling the shader:
:83:1 error: missing return at end of function
}
^

whisk.rs/:1 [Invalid ShaderModule "../shaders/point.wgsl"] is invalid.
 - While validating vertex stage ([Invalid ShaderModule "../shaders/point.wgsl"], entryPoint: vs_main).
 - While validating vertex state.
 - While calling [Device "egui wgpu device"].CreateRenderPipeline([RenderPipelineDescriptor "PointPainter pipeline"]).

7[Invalid RenderPipeline "line pipeline"] is invalid.
 - While encoding [RenderPassEncoder "egui_render"].SetPipeline([Invalid RenderPipeline "line pipeline"]).

123[Invalid CommandBuffer "egui_webpainter_paint_and_update_textures" from CommandEncoder "egui_webpainter_paint_and_update_textures"] is invalid.
 - While calling [Queue].Submit([[Invalid CommandBuffer "egui_webpainter_paint_and_update_textures" from CommandEncoder "egui_webpainter_paint_and_update_textures"]])

whisk.rs/:1 Texture size ([Extent3D width:9600, height:4800, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

117Could not create the swapchain texture.
    at APIInjectError (..<URL>)

117[Invalid Texture] is invalid.
 - While calling [Invalid Texture].CreateView([TextureViewDescriptor]).

116[Invalid TextureView] is invalid.
 - While validating colorAttachments[0].
 - While encoding [CommandEncoder "egui_webpainter_paint_and_update_textures"].BeginRenderPass([null]).

whisk.rs/:1 Texture size ([Extent3D width:19200, height:9600, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:38400, height:19200, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:76800, height:38400, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:153600, height:76800, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:307200, height:153600, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:614400, height:307200, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:1228800, height:614400, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:2457600, height:1228800, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:4915200, height:2457600, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:9830400, height:4915200, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:19660800, height:9830400, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:33554432, height:19660800, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 Texture size ([Extent3D width:33554432, height:33554432, depthOrArrayLayers:1]) exceeded maximum texture size ([Extent3D width:8192, height:8192, depthOrArrayLayers:256]).
    at ValidateTextureSize (../../chromium/third_party/dawn/src/dawn/native/Texture.cpp:306)

whisk.rs/:1 WebGPU: too many warnings, no more warnings will be reported to the console for this GPUDevice.
abey79 commented 2 weeks ago

Thanks for reporting. I can reproduce. Apparently the demo is broken on all browsers.

abey79 commented 2 weeks ago

This broke with #151. I'm going to try to update to the latest egui/wgpu release.

abey79 commented 2 weeks ago

Root cause: https://github.com/emilk/egui/issues/4699