abh / geodns

DNS server with per-client targeted responses
Apache License 2.0
1.37k stars 191 forks source link

Change check for records to use lowercase representation #100

Closed suedadam closed 4 years ago

suedadam commented 7 years ago

https://github.com/abh/geodns/pull/99#event-968401955

abligh commented 7 years ago

What's the reasoning for this? From memory the RFCs specify them as upper case.

On 19 Feb 2017, at 20:54, Adam Syed notifications@github.com wrote:

99 (comment)

You can view, comment on, or merge this pull request online at:

https://github.com/abh/geodns/pull/100

Commit Summary

• Change check for records to use lowercase representation File Changes

• M zones.go (2) Patch Links:

https://github.com/abh/geodns/pull/100.patchhttps://github.com/abh/geodns/pull/100.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- Alex Bligh

suedadam commented 7 years ago

Exactly and the configs have them as lowercase, thought it'd be better to have them convert to lowercase so that existing users don't have to update their configs

On Sun, Feb 19, 2017 at 2:50 PM Alex Bligh notifications@github.com wrote:

What's the reasoning for this? From memory the RFCs specify them as upper case.

On 19 Feb 2017, at 20:54, Adam Syed notifications@github.com wrote:

99 (comment)

You can view, comment on, or merge this pull request online at:

https://github.com/abh/geodns/pull/100

Commit Summary

• Change check for records to use lowercase representation File Changes

• M zones.go (2) Patch Links:

https://github.com/abh/geodns/pull/100.patchhttps://github.com/abh/geodns/pull/100.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- Alex Bligh

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abh/geodns/pull/100#issuecomment-280956488, or mute the thread https://github.com/notifications/unsubscribe-auth/ADsxiw4uCPwUCX6RWUKsKRAP4mS9T66Mks5reMcagaJpZM4MFkiZ .