search

abh / geodns

DNS server with per-client targeted responses
Apache License 2.0
1.39k stars 193 forks source link

HEAD doesn't build with abh/go-metrics #59

Closed leifj closed 9 years ago

leifj commented 9 years ago

./metrics.go:26: cannot use metrics.NewHistogram(metrics.NewUniformSample(1800)) (type metrics.Histogram) as type metrics.StandardHistogram in assignment: need type assertion ./metrics.go:29: cannot use metrics.NewHistogram(metrics.NewExpDecaySample(600, 0.015)) (type metrics.Histogram) as type metrics.StandardHistogram in assignment: need type assertion ./metrics.go:32: cannot use metrics.NewGauge() (type metrics.Gauge) as type metrics.StandardGauge in assignment: need type assertion ./zone.go:85: cannot use metrics.NewMeter() (type metrics.Meter) as type metrics.StandardMeter in assignment: need type assertion

leifj commented 9 years ago

This is go1.2.1 btw

leifj commented 9 years ago

actually I think I'm wrong. I was looking at a local branch

abh commented 9 years ago

I think what you are saying is that I should make a godep file. :-)

leifj commented 9 years ago

On 2014-11-25 16:41, Ask Bjørn Hansen wrote:

I think what you are saying is that I should make a godep file. :-)

— Reply to this email directly or view it on GitHub https://github.com/abh/geodns/issues/59#issuecomment-64418895.

yeah maybe :-)

abh commented 9 years ago

Looks like I started on that in

commit 24ce842203c348e4b30eff00819a5f6384bb5235 Author: Ask Bjørn Hansen Date: Sun Oct 19 15:03:32 2014 -0700

Use godep to track dependencies

:-)