search

abhagupta / codepath-nodejs-pre-work

Repository for code path nodejs pre-work - Demonstrating a proxy server with CLI
0 stars 0 forks source link

[Node JS BootCamp] : Project 0: Proxy server ready for review #1

Open abhagupta opened 9 years ago

abhagupta commented 9 years ago

My app is complete. /cc @codepathreview @codepath

Please review.

Wanted to mention that saving to --logfile did not work. I had to change it to some other name (--logfile1) to make it work. (You may notice that --logfile in gif video as not working, but I got it working just now by changing it to --logfile1 argument.

Also, wanted to point our a mistake in the http://courses.codepath.com/snippets/intro_to_nodejs/prework#heading-destination-url section. The let argv = require('yargs') .default('host', '127.0.0.1:8000') .argv should be

let argv = require('yargs') .default('host', '127.0.0.1') .argv

codepathreview commented 9 years ago

Looks good! Hope you found this first project useful as a brief introduction or review of Node.js.

This was intended in part to give you a flavor for the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project once the bootcamp starts.

The next step is to continue working on extensions to your Node.js server. We will be confirming with you soon if you are going to be a part of the first Node.js bootcamp at Walmart Labs. Please email us at nodejs@codepath.com if you have any questions!

codepathreview commented 9 years ago

@abhagupta Thanks for pointing out the mistake, we have fixed it in docs. Glad you were able to find it and figure out the correct way to do it.