search

abhay123lp / tunesremote-plus

Automatically exported from code.google.com/p/tunesremote-plus
0 stars 0 forks source link

Sync from tunesremote-se #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This issue is to track changes resulting from syncing tunesremote-se code into 
tunesremote-plus.

TunesRemote-SE is a JavaSE client for desktops / laptops running 
Windows/Mac/Linux. See

http://code.google.com/p/tunesremote-se/

Original issue reported on code.google.com by nick.gl...@lycos.com on 11 Jun 2011 at 8:55

GoogleCodeExporter commented 8 years ago 
Attached is my initial patch to sync tunesremote-plus to tunesremote-se r41.
I have checked that tunesremote-plus builds after the patch but have not run it.

Changes include:
Better parsing of the now playing (canp) field.
current genre field (cang)
creating interface for PlaylistListener
explicit conversions to/from UTF-8
removing a couple of statics 

Melloware could you please review / submit.

Thanks

Nick

Original comment by nick.gl...@lycos.com on 11 Jun 2011 at 9:00

GoogleCodeExporter commented 8 years ago 
oops missed part.  updated patch

Original comment by nick.gl...@lycos.com on 11 Jun 2011 at 9:04

Attachments:

GoogleCodeExporter commented 8 years ago 
Nick great stuff.  I will review these on Monday and implement them.

Original comment by mellowaredev on 11 Jun 2011 at 12:24

GoogleCodeExporter commented 8 years ago 
Changes checked into SVN and look good to me.  I made one minor change instead 
of e.printStackTrace() i used the Android logger.  Thanks!

Original comment by mellowaredev on 13 Jun 2011 at 4:54

GoogleCodeExporter commented 8 years ago 
Nick,

It looks like the GetSpeakers function broke.  When it does the 
getNested("casp") it is throwing an exception about ClassCastException.

Original comment by mellowaredev on 14 Jun 2011 at 10:51

GoogleCodeExporter commented 8 years ago 
Add "casp" back into BRANCHES list in ResponseParser.java.  would appear i had 
a bad merge when updating to your latest and then merged mine back into yours.

I'd check for anything missing in STRINGS too.

Sorry.

Original comment by nick.gl...@lycos.com on 14 Jun 2011 at 11:57

GoogleCodeExporter commented 8 years ago 
Thanks fixed in SVN and uploading 2.3.9 to the Android Market.

Original comment by mellowaredev on 14 Jun 2011 at 1:03