The Artists list was failing with latest forked-daapd

[GoogleCodeExporter]

Q. What Android hardware device do you own?  (HTC Hero, Samsung Galaxy,
etc)

A: Samsung Galaxy S

Q. On what Android operating system version? (2.1, 2.2, Honeycomb 3.0.1
etc)

A: 2.3.3

Q. What DACP server, OS, and version? (OSX iTunes 10.1.2, Windows 7
MonkeyTunes 1.5.1 etc)

A: Forked-daapd 0.17, debian 6.0.2

Q. What TunesRemote+ version? (found on Menu->More->About)

A: trunk

Please provide any additional information below.

There was an EOFException that was not being caught, I've included a patch 
which fixes this in the ResponseParser

Original issue reported on code.google.com by david%co...@gtempaccount.com on 19 Jul 2011 at 1:34

Attachments:

• forked-daapd-fix.diff

[GoogleCodeExporter]

Hmm I see what this patch is doing but I am wondering if it is because of an 
invalid way forke-daapd is sending the data and not so much with the parser?  
What I am saying is the bug possibly in forked-daapd and not in TunesRemote+?

Original comment by mellowaredev on 19 Jul 2011 at 3:10

• Changed state: Accepted

[GoogleCodeExporter]

Hi, That could well be the case but the small bit of extra exception handling 
in the parser does seem to fix things and I don't think it would introduce any 
issues for other servers :) 

I was also having problems with the pause functionality with TunesRemote+ with 
forked-daapd. Separating out the pause / playpause calls seems to help. I've 
managed to patch that also if you would like to see that patch, I'm not sure 
how it would impact other servers though as I've nothing extra to test with. 

The final issue that I have is regarding the search, I am still looking into 
that to see what to problem is.

Original comment by david%co...@gtempaccount.com on 19 Jul 2011 at 3:40

[GoogleCodeExporter]

No I appreciate the work.  Attach any patches you want and I can always test 
them against MonkeyTunes or iTunes to make sure nothing else is broken.

Original comment by mellowaredev on 19 Jul 2011 at 3:49

[GoogleCodeExporter]

Thanks that's much appreciated,

Here is a patch that contains both the artist list and play / pause fixes.

I'll attach another when I get to the bottom of the search failure.

Original comment by david%co...@gtempaccount.com on 19 Jul 2011 at 4:02

Attachments:

• forked-daapd-fix.diff

[GoogleCodeExporter]

I have incorporated your patches and so far so good but i have created a BETA 
APK and put it on the downloads page for others to try to make sure nothing is 
broken...

Original comment by mellowaredev on 20 Jul 2011 at 12:14

[GoogleCodeExporter]

Will give it a shot this weekend, and let you know.

Original comment by cramermaurice@gmail.com on 22 Jul 2011 at 2:36

[GoogleCodeExporter]

Tried it out for a while now, and didn't experience any problems with the 
latest Beta.

Original comment by cramermaurice@gmail.com on 2 Aug 2011 at 1:07

[GoogleCodeExporter]

Released on Android Market v 2.4.1

Original comment by mellowaredev on 24 Aug 2011 at 8:42

• Changed state: Fixed