abhay123lp / tunesremote-plus

Automatically exported from code.google.com/p/tunesremote-plus
0 stars 0 forks source link

Fit cover art #72

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Q. What Android hardware device do you own?  (HTC Hero, Samsung Galaxy,
etc)

A: HTC Sensation

Q. On what Android operating system version? (2.1, 2.2, Honeycomb 3.0.1
etc)

A: 2.3.3

Q. What DACP server, OS, and version? (OSX iTunes 10.1.2, Windows 7
MonkeyTunes 1.5.1 etc)

A: Win 7 iTunes 10.3.1.55

Q. What TunesRemote+ version? (found on Menu->More->About)

A: 2.4.0

Please provide any additional information below.

Enhancement request:
Right now, cover arts are always resized to fill the screen, having them cut by 
about their half in landscape mode. I think there should be an option to have 
the album arts just fit the screen. This would also improve the cover art 
display quality on the high resolution screens of newer mobiles and especially 
the tablets.

Original issue reported on code.google.com by flo.marc...@gmail.com on 6 Aug 2011 at 8:09

GoogleCodeExporter commented 8 years ago
P.S. I really love TunesRemote+. I think you're doing a great job, guys! I just 
feel like the app would profit of some minor improvements to the landscape view.

Original comment by flo.marc...@gmail.com on 6 Aug 2011 at 8:12

GoogleCodeExporter commented 8 years ago
Others have asked about this before.  I am just the developer who took over 
this project from the original developer Jeffery Sharkey.  I am not sure what 
he had in mind when he did a lot of the things he did but his choice of 
centering and trimming of the album art.  

I can look into having the art display differently.

Original comment by mellowaredev on 7 Aug 2011 at 2:22

GoogleCodeExporter commented 8 years ago
I have a HTC sensation 4g with a qHD screen. The album art doesn't exactly show 
up right. I've attached a screenshot. It looks stretched. A better way would be 
if it simply fit the whole image and just had blank space at the bottom. I'm 
running Anroid 2.3.3, latest version of iTunes for OS X Lion, Tunes remote 2.4.0

Original comment by nleo...@gmail.com on 16 Aug 2011 at 2:48

Attachments:

GoogleCodeExporter commented 8 years ago
OK I added a BETA on the Downloads tab.  It adds a new Setting call Crop Album 
image which is checked by default.  Uncheck it and restart the application and 
it no longer crops the image and give you the real image centered.

Original comment by mellowaredev on 16 Aug 2011 at 7:02

GoogleCodeExporter commented 8 years ago
Sorry this BETA here:

http://code.google.com/p/tunesremote-plus/downloads/list

Original comment by mellowaredev on 16 Aug 2011 at 8:37

GoogleCodeExporter commented 8 years ago
Ok. Now it isn't cropped anymore. But now, on my device (HTC Sensation) the 
covers are very small (about 1x1 Inch). Something in between would be good. I 
would like it to fit the width (i.e. the smaller length) of the screen. Would 
that be possible?

Unfortunately it's rather complicated to take Android screenshots, otherwise I 
would have added a shot ...

Original comment by flo.marc...@gmail.com on 18 Aug 2011 at 8:15

GoogleCodeExporter commented 8 years ago
How funny. My HTC Sensation just got the Android 2.3.4 update, which empowers 
you to take screenshots by just holding power and pressing the home button :-). 
That's just perfect timing. Well, I added a screenshot for you.

By the way: The cover has the same size in portrait mode as in landscape mode.

Original comment by flo.marc...@gmail.com on 18 Aug 2011 at 8:28

Attachments:

GoogleCodeExporter commented 8 years ago
So android ImageViews have the following properties...

http://developer.android.com/reference/android/widget/ImageView.ScaleType.html

In Crop mode I am using CENTER_CROP and in non crop mode CENTER_INSIDE and 
letting Android do the rendering based on your screensize.

It could be that flipping to landscape mode is not triggering an Android redraw 
of the image.

Original comment by mellowaredev on 18 Aug 2011 at 8:37

GoogleCodeExporter commented 8 years ago
What about using fit_center? Ideally it should look something like this... 
Attached is a screenshot from the htc music app. And i had the same issue with 
tiny art in portrait mode too.

Original comment by nleo...@gmail.com on 18 Aug 2011 at 11:02

Attachments:

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
I tested FIT_CENTER and it is the exact same bahavior as CROP_INSIDE.

I then tried FIT_XY and it looks a little better, but not sure if you will like 
it.

BETA on DOwnloads page...

Original comment by mellowaredev on 19 Aug 2011 at 1:05

GoogleCodeExporter commented 8 years ago
Hm, that's not really what I expected neither. Right now, I've got not much 
time left, but next week I'll google a bit around and try to find out, if and 
how the picture can be scaled to the screen size.

But thanks for your efforts anyway!

Original comment by flo.marc...@gmail.com on 20 Aug 2011 at 3:28

GoogleCodeExporter commented 8 years ago
Honestly, after using the beta a bit, I must say: It's better to distort the 
covers than to have them fill the screen and crop some parts, even if some 
covers look a little silly like that.

I will anyway do a little research about fitting it into the screenn, next week.

Original comment by flo.marc...@gmail.com on 20 Aug 2011 at 3:34

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
OK I will leave the FITXY then unless I hear otherwise.

Original comment by mellowaredev on 20 Aug 2011 at 11:23

GoogleCodeExporter commented 8 years ago
Is this the final beta of this and last issue? Or other changes? Want me to 
give it a final test run then?

Original comment by cramermaurice@gmail.com on 21 Aug 2011 at 9:02

GoogleCodeExporter commented 8 years ago
Yes this is the final beta before 2.4.1 is released on the Market so if you 
wouldn't mind giving it a run?

Original comment by mellowaredev on 21 Aug 2011 at 1:11

GoogleCodeExporter commented 8 years ago
I'm not a developer at all but there must be some way to center an image and 
then scale it to fit within the constraints of either the X or Y axis while 
maintaining the aspect ratio of the image (e.g. like the screen shot I posted 
in comment 9). What about using the  Matrix.ScaleToFit CENTER? See 
http://developer.android.com/reference/android/graphics/Matrix.ScaleToFit.html#F
ILL . 

Original comment by nleo...@gmail.com on 22 Aug 2011 at 4:05

GoogleCodeExporter commented 8 years ago
If you read this doc more carefully you will see it is just delegating to 
Matrix.ScaleToFit.

http://developer.android.com/reference/android/widget/ImageView.ScaleType.html

Matrix.ScaleToFit CENTER = ScaleType.Fit_XY which is what I am using.

Original comment by mellowaredev on 22 Aug 2011 at 10:26

GoogleCodeExporter commented 8 years ago
I know the problem now.  Compare your screenshot again to TunesRemote+.  In 
your screenshot the Image is inside all the metadata and is probably pre set to 
be say 330x300 so when that developer calls XY it scales inside it nicely.

Jeff Sharkey has the whole Image as the size of your Android window which is 
NOT square like 480 x 320.  Jeff uses transparent overlays for the metadata to 
fade in and fade out.   So FIT_XY in our case is using the whole desktop 
480x320 and not the 300x300 your screenshot above is using.

Now it makes sense why Jeff cropped it in the first place.  He wanted it to be 
the full background for his transparent overlays.

Original comment by mellowaredev on 22 Aug 2011 at 11:13

GoogleCodeExporter commented 8 years ago
Released on Android Market v 2.4.1

Original comment by mellowaredev on 24 Aug 2011 at 8:42

GoogleCodeExporter commented 8 years ago

Original comment by mellowaredev on 24 Aug 2011 at 8:42

GoogleCodeExporter commented 8 years ago
Issue 82 has been merged into this issue.

Original comment by mellowaredev on 12 Dec 2011 at 10:49