abhaynikam / boring_generators

Boring generators aims to make your development faster by delegating boring setups to us.
https://www.boringgenerators.com/
MIT License
269 stars 25 forks source link

Add generator for rswag gem #83

Closed coolprobn closed 6 months ago

coolprobn commented 1 year ago

Tasks

coolprobn commented 1 year ago

@abhaynikam Could you take a look at this PR when you are free and let me know if you would like me to update anything?

Thanks for your time.

coolprobn commented 1 year ago

It was intentionally designed to raise for error if rspec is missing insttead of running our generators to install it. This was based on the assumption that in a Rails project user will either have minitest or rspec, if the user is using minitest then it doesn't make sense for them to add another test framework.

image

coolprobn commented 1 year ago

@abhaynikam Could you review this PR?

I have fixed the merge conflicts with the main branch now.

coolprobn commented 7 months ago

@abhaynikam I have updated the code to reflect your suggestions and have added Authentication for API as well as UI instead of showing a message for users to configure themselves.

I have replied to your comment on why I don't think rspec should be installed by us if it doesn't already exist. Let us discuss on that if needed.

coolprobn commented 6 months ago

@abhaynikam Bumping this up for the review from your side