abhaynikam / react-trix-rte

React wrapper for Trix rich text editor created by Basecamp
https://abhaynikam.github.io/react-trix-rte
MIT License
71 stars 10 forks source link

Adding a custom class to the trix-editor via className prop is not possible #30

Closed alejo4373 closed 3 years ago

alejo4373 commented 3 years ago

I need the ability to pass a custom class name to <trix-editor> because I want to override a css property that is set via the default trix.css. More specifically I want to override min-height because I want the editor to have different heights at different times.

It looks like we could accomplish this through trixEditorOptions.

I'm open to collaborating on this further.

abhaynikam commented 3 years ago

@alejo4373 Sounds good to me. Please feel free to raise a PR. 😊

alejo4373 commented 3 years ago

What do you think of updating storybook? It took me some time to figure how to implement the new story with the older API. See the change in API here for how to add parameters and decorators.

abhaynikam commented 3 years ago

We can log a separate issue for upgrading Storybook. Closing this issue as PR is merged.